Adding CellsToMultiPolygon #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curious what the thoughts are on repeat cells. The C API states in documentation "It is expected that all hexagons in the set have the same resolution and that the set contains no duplicates. Behavior is undefined if duplicates or multiple resolutions are present, and the algorithm may produce unexpected or invalid output." We can check against this and/or deduplicate cells as well, but I have just added the caveat to the docstring for now. |
isaacbrodsky
requested review from
nrabinowitz,
dfellis,
ajfriend,
jogly and
isaacbrodsky
isaacbrodsky
previously approved these changes
Aug 9, 2024
Pull Request Test Coverage Report for Build 10340944716Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Took a slightly different approach with this to build up a slice of GeoPolygons instead of a linked list. This felt more idiomatic to Go.